I don’t know if I updated and forgot since I read this comment last but that return statement is fixed. The syntaxhighlighting plugin I have been using keeps messing up my code and escaping the HTML characters. I am pretty sure all of the places that the code was being escaped have been fixed.

$return(
‘lat’ => $result->Placemark[0]->Point->coordinates[1];
‘lon’ => $result->Placemark[0]->Point->coordinates[0];
);

is no valid php code… so i guess that has to be…

$return = array(
‘lat’ => $result->Placemark[0]->Point->coordinates[1],
‘lon’ => $result->Placemark[0]->Point->coordinates[0]
);

If that is correct you can also avoid the $return = array(); a few lines above, as $return is always initialised in the in the if-then construction.

Best Regards,

Patrick

Why are you using index.php tot put the key to the registry ?
Isn’t it better to for example use the bootstrap file ?
Like this for example ?

protected function _initGoogleMapsKey()
{
defined(‘CONFIG_PATH’)
or define(‘CONFIG_PATH’, APPLICATION_PATH . ‘/configs/application.ini’);
Zend_Registry::set(‘google’, new Zend_Config_Ini(CONFIG_PATH, ‘google’));
}

I think this is best practice to configure the google maps key, as normally you do not touch index.php at all, or you should want to use another google framework version, which you can config in the index.php.

Best Regards,

Patrick

If I’m not mistaken, the only change you’ve proposed is moving the code to a “Service” class, as I am already making use of Zend_Http in pretty much the exact same way. By having this logic in a model, I am able to have utility methods and expose more methods without fudging the purpose of the class. In reality, it makes the most sense to incorporate both approaches, and retrieve the data for my Geocoder model from a Services class.

It’s not about the amount of work I need to do get lat and lon, I can reuse this class as many times as I want. It is more about providing a clean and intuitive interface to gathering geodata.

Cheers

Then create a Service class in your custom library. and use Zend_Http

$this->_httpClient->setUri("http://maps.google.com/maps/geo");
$this->_httpClient->setHeaders('Accept-Charset', 'ISO-8859-1,utf-8');
$this->_httpClient->setParameterGet(array(
'key' => $this->_key,
'output' => $this->_output,
'q' => $address,
));
$data = $this->_httpClient->request('GET');
return $data->getBody();


An adapter seems like a lot of work to get a lat long.

Thanks again!

-Jim